Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[torch] Add support for aten.selu #2640

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[torch] Add support for aten.selu #2640

merged 1 commit into from
Dec 14, 2023

Conversation

JianzheXiao
Copy link
Contributor

@JianzheXiao JianzheXiao commented Dec 13, 2023 •
edited by rsuderman
Loading

Add aten.selu operation to torch dialect.

@rsuderman rsuderman changed the title [Torch Dialect] Add support for aten.selu op [torch] Add support for aten.selu Dec 14, 2023
@rsuderman rsuderman merged commit 6ddeb1a into llvm:main Dec 14, 2023
5 checks passed
ramiro050
ramiro050 reviewed Dec 15, 2023
View reviewed changes
lib/Dialect/Torch/Transforms/DecomposeComplexOps.cpp
rewriter.create<AtenMinimumOp>(loc, resType, zeroTensor, input);
Value expInput = rewriter.create<AtenExpOp>(loc, resType, minZeroX);
Value expInputMinusOne = rewriter.create<AtenSubScalarOp>(loc, resType, expInput, constantOne, constantOne);
Value negativeOutput = rewriter.create<AtenMulScalarOp>(loc, resType, expInputMinusOne, alphaVal);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: these lines look a bit long. Make sure to format changes using git clang-format. See:

torch-mlir/docs/Torch-ops-E2E-implementation.md

Line 49 in 65f517b

4. Use `git clang-format HEAD~1` to automatically format your commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramiro050 ramiro050 ramiro050 left review comments

@rsuderman rsuderman rsuderman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JianzheXiao @rsuderman @ramiro050